From f704828f89d1166692e5075d32509ebb93560320 Mon Sep 17 00:00:00 2001 From: mirza-samad-ahmed-baig Date: Thu, 3 Jul 2025 17:43:40 +0500 Subject: [PATCH 1/2] Fix: Prevent infinite loops, enable reflection, and improve logging --- main.py | 2 +- tradingagents/agents/trader/trader.py | 7 +++++-- tradingagents/graph/trading_graph.py | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/main.py b/main.py index 6c8ae3d9..077dfb8e 100644 --- a/main.py +++ b/main.py @@ -18,4 +18,4 @@ _, decision = ta.propagate("NVDA", "2024-05-10") print(decision) # Memorize mistakes and reflect -# ta.reflect_and_remember(1000) # parameter is the position returns +ta.reflect_and_remember(1000) # parameter is the position returns diff --git a/tradingagents/agents/trader/trader.py b/tradingagents/agents/trader/trader.py index 282a8411..1b05c35d 100644 --- a/tradingagents/agents/trader/trader.py +++ b/tradingagents/agents/trader/trader.py @@ -16,8 +16,11 @@ def create_trader(llm, memory): past_memories = memory.get_memories(curr_situation, n_matches=2) past_memory_str = "" - for i, rec in enumerate(past_memories, 1): - past_memory_str += rec["recommendation"] + "\n\n" + if past_memories: + for i, rec in enumerate(past_memories, 1): + past_memory_str += rec["recommendation"] + "\n\n" + else: + past_memory_str = "No past memories found." context = { "role": "user", diff --git a/tradingagents/graph/trading_graph.py b/tradingagents/graph/trading_graph.py index eb06cf43..80a29e53 100644 --- a/tradingagents/graph/trading_graph.py +++ b/tradingagents/graph/trading_graph.py @@ -226,7 +226,7 @@ class TradingAgentsGraph: directory.mkdir(parents=True, exist_ok=True) with open( - f"eval_results/{self.ticker}/TradingAgentsStrategy_logs/full_states_log.json", + f"eval_results/{self.ticker}/TradingAgentsStrategy_logs/full_states_log_{trade_date}.json", "w", ) as f: json.dump(self.log_states_dict, f, indent=4) From c73e374e7c7229e3b731e961ce165a9b2da30916 Mon Sep 17 00:00:00 2001 From: Yijia Xiao <48253104+Yijia-Xiao@users.noreply.github.com> Date: Thu, 3 Jul 2025 10:14:06 -0400 Subject: [PATCH 2/2] Update main.py --- main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.py b/main.py index 077dfb8e..6c8ae3d9 100644 --- a/main.py +++ b/main.py @@ -18,4 +18,4 @@ _, decision = ta.propagate("NVDA", "2024-05-10") print(decision) # Memorize mistakes and reflect -ta.reflect_and_remember(1000) # parameter is the position returns +# ta.reflect_and_remember(1000) # parameter is the position returns