From 9ff531f2934001d9912ac9d74026d50031403ffc Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 22 Mar 2026 06:02:39 +0000
Subject: [PATCH] fix: address review feedback on PR #85 dataflows hardening

- y_finance.py: replace print() with logger.warning() in bulk-stats fallback
- macro_bridge.py: add elapsed_seconds field to TickerResult, populate in
  run_ticker_analysis (success + error paths)
- cli/main.py: move inline 'import time as _time' and rich.progress imports
  to module level; use result.elapsed_seconds for accurate per-ticker timing

Co-authored-by: aguzererler <6199053+aguzererler@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aguzererler/TradingAgents/sessions/68fcf34c-8d55-4436-b743-f79fff68713f
---
 cli/main.py                            | 13 ++++++-------
 tradingagents/dataflows/y_finance.py   |  2 +-
 tradingagents/pipeline/macro_bridge.py |  3 +++
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/cli/main.py b/cli/main.py
index da5932aa..b53fefa9 100644
--- a/cli/main.py
+++ b/cli/main.py
@@ -27,6 +27,7 @@ import time
 from rich import box
 from rich.align import Align
 from rich.rule import Rule
+from rich.progress import Progress, SpinnerColumn, BarColumn, TextColumn, TimeElapsedColumn
 
 from tradingagents.graph.trading_graph import TradingAgentsGraph
 from tradingagents.report_paths import get_daily_dir, get_market_dir, get_ticker_dir
@@ -1588,10 +1589,8 @@ def run_pipeline(
             f"  [dim]{c.sector} · {c.conviction.upper()} conviction[/dim]"
         )
     console.print()
-    import time as _time
-    from rich.progress import Progress, SpinnerColumn, BarColumn, TextColumn, TimeElapsedColumn
 
-    pipeline_start = _time.monotonic()
+    pipeline_start = time.monotonic()
 
     with Progress(
         SpinnerColumn(),
@@ -1605,17 +1604,17 @@ def run_pipeline(
         overall = progress.add_task("[bold]Pipeline progress[/bold]", total=len(candidates))
 
         def on_done(result, done_count, total_count):
-            ticker_elapsed = _time.monotonic() - pipeline_start
+            ticker_elapsed = result.elapsed_seconds
             if result.error:
                 console.print(
                     f"  [red]✗ {result.ticker}[/red]"
-                    f"  [dim]failed ({ticker_elapsed:.0f}s elapsed) — {result.error[:80]}[/dim]"
+                    f"  [dim]failed ({ticker_elapsed:.0f}s) — {result.error[:80]}[/dim]"
                 )
             else:
                 decision_preview = str(result.final_trade_decision)[:70].replace("\n", " ")
                 console.print(
                     f"  [green]✓ {result.ticker}[/green]"
-                    f"  [dim]({done_count}/{total_count}, {ticker_elapsed:.0f}s elapsed)[/dim]"
+                    f"  [dim]({done_count}/{total_count}, {ticker_elapsed:.0f}s)[/dim]"
                     f"  → {decision_preview}"
                 )
             progress.advance(overall)
@@ -1631,7 +1630,7 @@ def run_pipeline(
             console.print(f"[red]Pipeline failed: {e}[/red]")
             raise typer.Exit(1)
 
-    elapsed_total = _time.monotonic() - pipeline_start
+    elapsed_total = time.monotonic() - pipeline_start
     console.print(
         f"\n[bold green]All {len(candidates)} ticker(s) finished in {elapsed_total:.0f}s[/bold green]\n"
     )
diff --git a/tradingagents/dataflows/y_finance.py b/tradingagents/dataflows/y_finance.py
index 7682184a..2c393659 100644
--- a/tradingagents/dataflows/y_finance.py
+++ b/tradingagents/dataflows/y_finance.py
@@ -168,7 +168,7 @@ def get_stock_stats_indicators_window(
             ind_string += f"{date_str}: {value}\n"
         
     except Exception as e:
-        print(f"Error getting bulk stockstats data: {e}")
+        logger.warning("Bulk stockstats failed for %s/%s, falling back to per-day loop: %s", symbol, indicator, e)
         # Fallback to original implementation if bulk method fails
         ind_string = ""
         curr_date_dt = datetime.strptime(curr_date, "%Y-%m-%d")
diff --git a/tradingagents/pipeline/macro_bridge.py b/tradingagents/pipeline/macro_bridge.py
index e18c6ef9..637c1256 100644
--- a/tradingagents/pipeline/macro_bridge.py
+++ b/tradingagents/pipeline/macro_bridge.py
@@ -70,6 +70,7 @@ class TickerResult:
     final_trade_decision: str = ""
 
     error: str | None = None
+    elapsed_seconds: float = 0.0
 
 
 # ─── Parsing ──────────────────────────────────────────────────────────────────
@@ -207,6 +208,7 @@ def run_ticker_analysis(
         result.final_trade_decision = decision
 
         elapsed = time.monotonic() - t0
+        result.elapsed_seconds = elapsed
         logger.info(
             "[%s] ✓ Analysis complete in %.0fs — decision: %s",
             candidate.ticker, elapsed, str(decision)[:80],
@@ -214,6 +216,7 @@ def run_ticker_analysis(
 
     except Exception as exc:
         elapsed = time.monotonic() - t0
+        result.elapsed_seconds = elapsed
         logger.error(
             "[%s] ✗ Analysis FAILED after %.0fs: %s",
             candidate.ticker, elapsed, exc, exc_info=True,