From 51491ca678a2d7e79dbb58bc241b3336fd684bb5 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 17 Mar 2026 20:05:58 +0000 Subject: [PATCH] docs: document git remote setup (origin = aguzererler fork) origin points to aguzererler/TradingAgents which IS the fork. No upstream remote configured. All feature branches push to origin. https://claude.ai/code/session_01TuPpssTo83whKkNgSu57HH --- DECISIONS.md | 17 ++++++++++++++++- MISTAKES.md | 14 ++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/DECISIONS.md b/DECISIONS.md index 92f10194..0c554680 100644 --- a/DECISIONS.md +++ b/DECISIONS.md @@ -102,7 +102,22 @@ Download 6 months of history via `yf.download()` and compute 1-day, 1-week, 1-mo --- -## Decision 008: Medium-Term Upgrade — Macro Regime via yfinance Only +## Decision 008: Git Remote Strategy — origin = fork + +**Date**: 2026-03-17 +**Status**: Documented ✅ + +**Setup**: There is only one configured remote: +``` +origin → http://127.0.0.1:46699/git/aguzererler/TradingAgents (the user's fork) +``` +No `upstream` remote for the parent repo. + +**Rule**: Always push feature branches to `origin`. Never push directly to `main`. PRs are created from `claude/*` branches on the fork via the Gitea web UI (no `gh` CLI available). + +--- + +## Decision 009: Medium-Term Upgrade — Macro Regime via yfinance Only **Date**: 2026-03-17 **Status**: Implemented ✅ diff --git a/MISTAKES.md b/MISTAKES.md index 3b40c839..0718f0af 100644 --- a/MISTAKES.md +++ b/MISTAKES.md @@ -121,6 +121,20 @@ f"| Debt / Equity | {(str(round(ttm['debt_to_equity'], 2)) + 'x') if ... else 'N --- +## Mistake 12: Remote naming — "origin" is the fork, not the upstream + +**What happened**: Confusion about which remote is the "fork" vs "origin". The user said "you pushed to origin, not the fork" — but there is only one remote configured, and it points to `aguzererler/TradingAgents` which IS the fork. + +**Setup**: +``` +origin → http://127.0.0.1:46699/git/aguzererler/TradingAgents ← this IS the fork +``` +There is no separate `upstream` remote for the original/parent repo. + +**Lesson**: In this project, `origin` = the user's fork (`aguzererler/TradingAgents`). Always push development branches to `origin`. If an `upstream` remote is ever added, never push feature branches to it — only fetch from it. + +--- + ## Mistake 9: Removed top-level `llm_provider` but code still references it **What happened**: Removed `llm_provider` from `default_config.py` (since we have per-tier providers). But `scanner_graph.py` line 78 does `self.config.get(f"{tier}_llm_provider") or self.config["llm_provider"]` — would crash if per-tier provider is ever None.